This repository was archived by the owner on May 1, 2024. It is now read-only.
Solves [Bug] #595 Setting TabView.SelectedIndex does not "visually" switch tabs #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting TabView.SelectedIndex does not "visually" switch tabs
jsuarezruiz
approved these changes
Jan 9, 2021
jsuarezruiz
suggested changes
Jan 11, 2021
| @@ -745,12 +745,10 @@ bool CanUpdateSelectedIndex(int selectedIndex) | |||
| return true; | |||
| } | |||
|
|
|||
| void UpdateSelectedIndex(int position, bool hasCurrentItem = false) | |||
| void UpdateSelectedIndex(int oldPosition, int position, bool hasCurrentItem = false) | |||
There was a problem hiding this comment.
Is it simpler perhaps, to validate the old and new index before invoking UpdateSelectedIndex?. Could you add an example where validate the fix?
ghost
deleted a comment from
Validate the old and new index before invoking UpdateSelectedIndex as suggested
|
|
jfversluis
previously approved these changes
Jan 21, 2021
|
I think this is now solved by #903 |
|
Maybe I was too quick on this 😬 |
Fixes xamarin#595 Added simple test Maybe related to xamarin#870
|
Example forked and updated from: @MauricioCodeguez |
jfversluis
approved these changes
Feb 22, 2021
jfversluis
approved these changes
Feb 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting TabView.SelectedIndex does not "visually" switch tabs
Description of Change
Solves setting TabView.SelectedIndex does not "visually" switch tabs
Adding oldPosition value to UpdateSelectedIndex function in UpdateSelectedIndex avoids the false true on
if (oldPosition == newPosition)Bugs Fixed
#595
API Changes
None
Added:
oldPositiononTabView.shared.UpdateSelectedIndexPR Checklist